fix(web): order compact sidebar icons as terminal, pr, status - #11676
maria-rcks wants to merge 1 commit into
Conversation
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This one-line change only reorders existing compact sidebar icons to terminal, pull request, and status, without altering their behavior or adding new logic. Its runtime impact is limited to presentation order in the web UI. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe compact sidebar row now renders the pull-request badge before the status indicator. The displayed badge remains unchanged. ChangesCompact sidebar row
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The compact sidebar now uses the requested indicator order, and no merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Superseded by #11685 (merged) — compact sidebar was reverted, so this change no longer applies. |
2 participants
In compact (one-line) thread rows the pull-request badge rendered after the thread status icon, so a row with both read
status, pr. The status belongs closest to the timestamp: the terminal indicator first, then the PR badge, then the status icon. Wide card rows are unchanged.Both screenshots are the same thread mid-turn (
Working) with its linked pull request, captured in a real dev server with compact thread rows enabled.Before —
working, pr:After —
pr, working:Verification
vp run --filter @t3tools/web typecheck,vp lint apps/web/src/components/Sidebar.tsx(0 errors), and the fourSidebar.*test files (236 passed) are clean on Blacksmith. Terminal position is unchanged (first when present); no seeded row had a running terminal to show it.